changes reverted in mqtt

src/controllers/tanksController.js

@@ -5893,101 +5893,98 @@ exports.getBlockData = async (req, reply) => {
 
 
 
-const mqtt = require('mqtt');
-require('dotenv').config();
-
-const activeClients = new Map(); // Store active clients per hw_Id
 
-// Start a persistent temp client to listen for multiple devices
-const tempClientId = `mqtt_temp_${Math.random().toString(16).substr(2, 8)}`;
-const tempClient = connectMQTT(tempClientId, true);
 
-// Function to create an MQTT client
-function connectMQTT(clientId, isTemp = false, hw_Id = null) {
-  console.log(`🔄 Connecting to MQTT with clientId: ${clientId}`);
+const mqtt = require('mqtt');
+require('dotenv').config();
 
-  const newClient = mqtt.connect('mqtt://35.207.198.4:1883', {
-    clientId,
-    clean: false, // Ensures session persistence
+// **Persistent MQTT Connection**
+const client = mqtt.connect('mqtt://35.207.198.4:1883', {
+  clientId: `mqtt_server_${Math.random().toString(16).substr(2, 8)}`,
+  clean: false, // Ensures MQTT retains subscriptions
   reconnectPeriod: 2000, // Reconnect every 2 seconds
-    keepalive: 60, // Maintain connection
-  });
+});
+
+const subscribedTopics = new Set();
+const activeDevices = new Set(); // Keep track of active devices
 
-  newClient.on('connect', () => {
-    console.log(`✅ Connected to MQTT broker as ${clientId}`);
+client.on('connect', () => {
+  console.log('✅ Connected to MQTT broker');
 
-    if (isTemp) {
-      // Temporary client listens for multiple device announcements
-      newClient.subscribe('water/iot-data/announce', { qos: 1 }, (err) => {
+  // **Ensure re-subscriptions after reconnect**
+  subscribedTopics.forEach(topic => {
+    client.subscribe(topic, { qos: 1 }, (err) => {
       if (err) {
-          console.error('❌ Error subscribing to announcement topic:', err);
+        console.error(`❌ Error resubscribing to ${topic}:`, err);
       } else {
-          console.log('📡 Subscribed to water/iot-data/announce');
+        console.log(`🔄 Resubscribed to ${topic}`);
       }
     });
-    } else if (hw_Id) {
-      // If this is the actual device client, subscribe to its topic
-      const deviceTopic = `water/iot-data/${hw_Id}`;
-      newClient.subscribe(deviceTopic, { qos: 1 }, (err) => {
+  });
+
+  // **Subscribe to new device announcements**
+  client.subscribe('water/iot-data/announce', { qos: 1 }, (err) => {
     if (err) {
-          console.error(`❌ Error subscribing to ${deviceTopic}:`, err);
+      console.error('❌ Error subscribing to announcement topic:', err);
     } else {
-          console.log(`✅ Subscribed to ${deviceTopic}`);
-          logActiveClients(); // Log clients after each new device connects
-        }
-      });
+      console.log('📡 Subscribed to water/iot-data/announce');
     }
   });
+});
 
-  newClient.on('message', async (topic, message) => {
+client.on('message', async (topic, message) => {
   console.log(`📩 Message received on topic ${topic}: ${message.toString()}`);
 
   try {
     const data = JSON.parse(message.toString());
 
-      if (topic === 'water/iot-data/announce' && isTemp) {
+    // **Handle device announcements**
+    if (topic === 'water/iot-data/announce') {
       if (!data.objects || !data.objects.hw_Id) {
         console.error("❌ Invalid announcement format. Missing hw_Id.");
         return;
       }
 
       const hw_Id = data.objects.hw_Id;
-        console.log(`🔄 New Device Found! hw_Id: ${hw_Id}`);
+      const deviceTopic = `water/iot-data/${hw_Id}`;
 
-        // If this device hasn't been connected yet, create a client for it
-        if (!activeClients.has(hw_Id)) {
-          console.log(`🔄 Creating new MQTT client for hw_Id: ${hw_Id}`);
-          activeClients.set(hw_Id, connectMQTT(`mqtt_client_${hw_Id}`, false, hw_Id));
+      if (!subscribedTopics.has(deviceTopic)) {
+        client.subscribe(deviceTopic, { qos: 1 }, (err) => {
+          if (err) {
+            console.error(`❌ Error subscribing to ${deviceTopic}:`, err);
+          } else {
+            console.log(`✅ Subscribed to ${deviceTopic}`);
+            subscribedTopics.add(deviceTopic);
+            activeDevices.add(hw_Id);
+            console.log('📡 Active Devices:', Array.from(activeDevices));
+
+            // ✅ **Now also process data**
+            processIotData(hw_Id, data);
           }
+        });
+      } else {
+        console.log(`🔄 Already subscribed to ${deviceTopic}, processing data.`);
+        processIotData(hw_Id, data);
+      }
+      return;
     }
 
+    // **Process IoT Data for device topics**
     if (topic.startsWith('water/iot-data/')) {
       setImmediate(() => {
-          console.log(`🚀 Processing IoT Data for topic: ${topic}`);
-          const deviceHwId = topic.split('/')[2];
-          processIotData(deviceHwId, data);
+        console.log(`🚀 Entering processIotData() for topic: ${topic}`);
+        const hw_Id = topic.split('/')[2];
+        processIotData(hw_Id, data);
       });
     }
   } catch (err) {
     console.error('❌ Error processing message:', err.message);
   }
-  });
-
-  newClient.on('error', (err) => console.error('❌ MQTT Error:', err));
-  newClient.on('close', () => console.log(`⚠️ MQTT Connection Closed for ${clientId}`));
-  newClient.on('offline', () => console.log(`⚠️ MQTT Broker Offline for ${clientId}`));
-
-  return newClient;
-}
-
-// Function to log active MQTT clients
-function logActiveClients() {
-  console.log(`\n📡 Active MQTT Clients:`);
-  activeClients.forEach((client, hw_Id) => {
-    console.log(`   🔹 Client ID: mqtt_client_${hw_Id}`);
-  });
-}
+});
 
+client.on('error', (err) => console.error('❌ MQTT Error:', err));
+client.on('close', () => console.log('⚠️ MQTT Connection Closed.'));
+client.on('offline', () => console.log('⚠️ MQTT Broker Offline.'));
 
 async function processIotData(hw_Id, data) {
   try {
@@ -6103,6 +6100,9 @@ async function processIotData(hw_Id, data) {
 }
 
 
+
+
+
 // function logSets() {
 //   console.log("Subscribed Topics:", Array.from(subscribedTopics));
 //   console.log("Active Devices:", Array.from(activeDevices));