diff --git a/src/controllers/tanksController.js b/src/controllers/tanksController.js index 041f792b..c3437349 100644 --- a/src/controllers/tanksController.js +++ b/src/controllers/tanksController.js @@ -5893,101 +5893,98 @@ exports.getBlockData = async (req, reply) => { + + const mqtt = require('mqtt'); require('dotenv').config(); -const activeClients = new Map(); // Store active clients per hw_Id +// **Persistent MQTT Connection** +const client = mqtt.connect('mqtt://35.207.198.4:1883', { + clientId: `mqtt_server_${Math.random().toString(16).substr(2, 8)}`, + clean: false, // Ensures MQTT retains subscriptions + reconnectPeriod: 2000, // Reconnect every 2 seconds +}); -// Start a persistent temp client to listen for multiple devices -const tempClientId = `mqtt_temp_${Math.random().toString(16).substr(2, 8)}`; -const tempClient = connectMQTT(tempClientId, true); +const subscribedTopics = new Set(); +const activeDevices = new Set(); // Keep track of active devices -// Function to create an MQTT client -function connectMQTT(clientId, isTemp = false, hw_Id = null) { - console.log(`šŸ”„ Connecting to MQTT with clientId: ${clientId}`); +client.on('connect', () => { + console.log('āœ… Connected to MQTT broker'); - const newClient = mqtt.connect('mqtt://35.207.198.4:1883', { - clientId, - clean: false, // Ensures session persistence - reconnectPeriod: 2000, // Reconnect every 2 seconds - keepalive: 60, // Maintain connection + // **Ensure re-subscriptions after reconnect** + subscribedTopics.forEach(topic => { + client.subscribe(topic, { qos: 1 }, (err) => { + if (err) { + console.error(`āŒ Error resubscribing to ${topic}:`, err); + } else { + console.log(`šŸ”„ Resubscribed to ${topic}`); + } + }); }); - newClient.on('connect', () => { - console.log(`āœ… Connected to MQTT broker as ${clientId}`); - - if (isTemp) { - // Temporary client listens for multiple device announcements - newClient.subscribe('water/iot-data/announce', { qos: 1 }, (err) => { - if (err) { - console.error('āŒ Error subscribing to announcement topic:', err); - } else { - console.log('šŸ“” Subscribed to water/iot-data/announce'); - } - }); - } else if (hw_Id) { - // If this is the actual device client, subscribe to its topic - const deviceTopic = `water/iot-data/${hw_Id}`; - newClient.subscribe(deviceTopic, { qos: 1 }, (err) => { - if (err) { - console.error(`āŒ Error subscribing to ${deviceTopic}:`, err); - } else { - console.log(`āœ… Subscribed to ${deviceTopic}`); - logActiveClients(); // Log clients after each new device connects - } - }); + // **Subscribe to new device announcements** + client.subscribe('water/iot-data/announce', { qos: 1 }, (err) => { + if (err) { + console.error('āŒ Error subscribing to announcement topic:', err); + } else { + console.log('šŸ“” Subscribed to water/iot-data/announce'); } }); +}); - newClient.on('message', async (topic, message) => { - console.log(`šŸ“© Message received on topic ${topic}: ${message.toString()}`); - - try { - const data = JSON.parse(message.toString()); - - if (topic === 'water/iot-data/announce' && isTemp) { - if (!data.objects || !data.objects.hw_Id) { - console.error("āŒ Invalid announcement format. Missing hw_Id."); - return; - } +client.on('message', async (topic, message) => { + console.log(`šŸ“© Message received on topic ${topic}: ${message.toString()}`); - const hw_Id = data.objects.hw_Id; - console.log(`šŸ”„ New Device Found! hw_Id: ${hw_Id}`); + try { + const data = JSON.parse(message.toString()); - // If this device hasn't been connected yet, create a client for it - if (!activeClients.has(hw_Id)) { - console.log(`šŸ”„ Creating new MQTT client for hw_Id: ${hw_Id}`); - activeClients.set(hw_Id, connectMQTT(`mqtt_client_${hw_Id}`, false, hw_Id)); - } + // **Handle device announcements** + if (topic === 'water/iot-data/announce') { + if (!data.objects || !data.objects.hw_Id) { + console.error("āŒ Invalid announcement format. Missing hw_Id."); + return; } - if (topic.startsWith('water/iot-data/')) { - setImmediate(() => { - console.log(`šŸš€ Processing IoT Data for topic: ${topic}`); - const deviceHwId = topic.split('/')[2]; - processIotData(deviceHwId, data); + const hw_Id = data.objects.hw_Id; + const deviceTopic = `water/iot-data/${hw_Id}`; + + if (!subscribedTopics.has(deviceTopic)) { + client.subscribe(deviceTopic, { qos: 1 }, (err) => { + if (err) { + console.error(`āŒ Error subscribing to ${deviceTopic}:`, err); + } else { + console.log(`āœ… Subscribed to ${deviceTopic}`); + subscribedTopics.add(deviceTopic); + activeDevices.add(hw_Id); + console.log('šŸ“” Active Devices:', Array.from(activeDevices)); + + // āœ… **Now also process data** + processIotData(hw_Id, data); + } }); + } else { + console.log(`šŸ”„ Already subscribed to ${deviceTopic}, processing data.`); + processIotData(hw_Id, data); } - } catch (err) { - console.error('āŒ Error processing message:', err.message); + return; } - }); - - newClient.on('error', (err) => console.error('āŒ MQTT Error:', err)); - newClient.on('close', () => console.log(`āš ļø MQTT Connection Closed for ${clientId}`)); - newClient.on('offline', () => console.log(`āš ļø MQTT Broker Offline for ${clientId}`)); - - return newClient; -} -// Function to log active MQTT clients -function logActiveClients() { - console.log(`\nšŸ“” Active MQTT Clients:`); - activeClients.forEach((client, hw_Id) => { - console.log(` šŸ”¹ Client ID: mqtt_client_${hw_Id}`); - }); -} + // **Process IoT Data for device topics** + if (topic.startsWith('water/iot-data/')) { + setImmediate(() => { + console.log(`šŸš€ Entering processIotData() for topic: ${topic}`); + const hw_Id = topic.split('/')[2]; + processIotData(hw_Id, data); + }); + } + } catch (err) { + console.error('āŒ Error processing message:', err.message); + } +}); +client.on('error', (err) => console.error('āŒ MQTT Error:', err)); +client.on('close', () => console.log('āš ļø MQTT Connection Closed.')); +client.on('offline', () => console.log('āš ļø MQTT Broker Offline.')); async function processIotData(hw_Id, data) { try { @@ -6103,6 +6100,9 @@ async function processIotData(hw_Id, data) { } + + + // function logSets() { // console.log("Subscribed Topics:", Array.from(subscribedTopics)); // console.log("Active Devices:", Array.from(activeDevices));